Dynamic campaign audience - #2695
Open
adelowo wants to merge 2 commits into
Open
Conversation
adelowo
force-pushed
the
feat-ISS-2676
branch
2 times, most recently
from
August 24, 2026 21:53
2c45fcf to
81eb643
Compare
adelowo
marked this pull request as ready for review
August 26, 2026 10:54
Comment on lines
+70
to
+73
| field.String("email"). | ||
| Comment("the email address for this audience member"). | ||
| NotEmpty(). | ||
| Annotations( |
Member
There was a problem hiding this comment.
Why doe this have to be not empty? Can't it be from one of the edges?
Member
Author
There was a problem hiding this comment.
we can do that but I opted for this for 2 reasons:
- I'd suppose I will want to have a view of those I sent the campaign to later on. if we update the email of an identity_holder/contact for some reason, we may lose the original one we have
- will get more complex where we have to track which schema has the id
adelowo
enabled auto-merge (squash)
August 28, 2026 18:31
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Dynamic audience
Manual audience where they are defined upfront